Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better support for relative constraints #213

Merged
merged 11 commits into from
Sep 26, 2021

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Sep 24, 2021

  • download_url
  • search_url
  • ensure it is only used in tabledap let's let ERDDAP handle failed URLs upstream. Users should read the docs.
  • add example/docs

@ocefpaf ocefpaf force-pushed the relative_constraints branch from 5d47610 to 6387668 Compare September 24, 2021 23:47
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 25, 2021

This introduces a breaking change to those using relative constraints that was added by @thogar-computer awesome PR in #162. However, the fix is easy, just merge all constraints into a single kwargs!

Closes #212

@ocefpaf ocefpaf merged commit 7aa1c6e into ioos:main Sep 26, 2021
@ocefpaf ocefpaf deleted the relative_constraints branch September 27, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant