✨ Prepare kamaji setup #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
piepmatz
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Assuming users need to provide the control plane endpoint host or IP anyway, skipping that step basically has 2 consequences:
- We no longer store the IP block ID in the status. Running
ReconcileControlPlaneEndpointDeletionunconditionally is a bit more expensive then. - An unset controlplane endpoint port is no longer defaulted to
6443. When using our templates, the port is always set initially, but the code allows skipping it.
jriedel-ionos
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request/Why do we need it?
We need to make sure, not to reconcile IP Blocks for the control plane, if we do not specify a LB controller.
Description of changes:
This change is required for a setup with Kamaji. The logic needs to be moved in the future anyways and automatically reserving IP Blocks for a HA control plane was not yet supported anyways
Checklist: