Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add short name and categories to CRD #121

Merged
merged 2 commits into from
May 15, 2024
Merged

🌱 Add short name and categories to CRD #121

merged 2 commits into from
May 15, 2024
+12 −0

Conversation

avorima
Copy link
Contributor

@avorima avorima commented May 14, 2024 •
edited
Loading

What is the purpose of this pull request/Why do we need it?

Issue #, if available:

Description of changes:

kubectl get icc         # Show IonosCloudClusters
kubectl get icm         # Show IonosCloudMachines
kubectl get cluster-api # Now includes ionoscloud resources
kubectl get ionoscloud  # Show ionoscloud resources

Special notes for your reviewer:

Checklist:

  • Documentation updated
  • Unit Tests added
  • E2E Tests added
  • Includes emojis

jriedel-ionos
jriedel-ionos previously approved these changes May 15, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@avorima avorima merged commit 1ae8d18 into main May 15, 2024
9 checks passed
@avorima avorima deleted the add-short-names branch May 15, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jriedel-ionos jriedel-ionos jriedel-ionos approved these changes

@piepmatz piepmatz Awaiting requested review from piepmatz piepmatz is a code owner

@lubedacht lubedacht Awaiting requested review from lubedacht

@gfariasalves-ionos gfariasalves-ionos Awaiting requested review from gfariasalves-ionos gfariasalves-ionos is a code owner

@mcbenjemaa mcbenjemaa Awaiting requested review from mcbenjemaa mcbenjemaa is a code owner

@wikkyk wikkyk Awaiting requested review from wikkyk wikkyk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avorima @jriedel-ionos