Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): broken markdown for the options table in the README.md file #465

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

dgonzalezr
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The current markdown table that describes the output target options in the README.md file is broken, the last two options are visualized outside of the table, which I consider is not the intention.

CleanShot 2024-08-28 at 16 19 20

Issue URL:

What is the new behavior?

Just a very short change to fix the markdown of the output target options table on the README.md file of the react-output-target.

CleanShot 2024-08-28 at 16 20 00

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dgonzalezr dgonzalezr requested review from a team as code owners August 28, 2024 13:22
@dgonzalezr dgonzalezr changed the title docs(react): output target options table broken in the README.md file docs(react): broken markdown for the options table in the README.md file Aug 28, 2024
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👌

@christian-bromann christian-bromann enabled auto-merge (squash) August 28, 2024 14:54
@christian-bromann christian-bromann merged commit 75c6cce into ionic-team:main Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants