fix(scrollView): reset scroll view when focusing non-keyboard element #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focusing a keyboard element sets `keyboardActiveElement`. If you blur, this will trigger `resetScrollView` appropriately. If you focus a non-keyboard element, `keyboardActiveElement` is set to null *before* `keyboardHide` is called, so `resetScrollView` is not triggered. Mitigate this by keeping track of the last focused element to reset the scroll view.
This was referenced Jul 20, 2015
mlynch
added a commit
that referenced
this pull request
Dec 6, 2015
fix(scrollView): reset scroll view when focusing non-keyboard element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focusing a keyboard element sets
keyboardActiveElement. If you blur,this will trigger
resetScrollViewappropriately.If you focus a non-keyboard element (such as a checkbox),
keyboardActiveElementis set tonull before
keyboardHideis called, soresetScrollViewis nottriggered.
Mitigate this by keeping track of the last focused element to reset the
scroll view.