Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(picker-column-internal): switching off an input mode column preserves scroll #25467

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 14, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Sean reported an issue where quickly blurring a picker column with numericInput="true" causes the scroll position to get reset back to whatever it was at when the scroll gesture started. This was because we updated this.isActive mid-scroll. isActive is a state variable which causes a re-render whenever its value changes. This resulted in a re-render happening mid scroll.

What is the new behavior?

  • Updated the internal logic to only update isActive once scrolling is done.
  • If no scrolling is happening then isActive will be set right away

Does this introduce a breaking change?

  • Yes
  • No

Other information

main branch
before-picker-col.mov
after-picker-col.mov

Note: Capturing an automated test for this is difficult on CI because of how quick the focus change needs to happen. I recommend testing manually at http://localhost:3333/src/components/picker-internal/test/basic on the numeric input pickers.

@github-actions github-actions bot added the package: core @ionic/core package label Jun 14, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review June 14, 2022 16:58
@liamdebeasi liamdebeasi requested a review from a team as a code owner June 14, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants