fix(picker-column-internal): switching off an input mode column preserves scroll #25467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Sean reported an issue where quickly blurring a picker column with
numericInput="true"
causes the scroll position to get reset back to whatever it was at when the scroll gesture started. This was because we updatedthis.isActive
mid-scroll.isActive
is a state variable which causes a re-render whenever its value changes. This resulted in a re-render happening mid scroll.What is the new behavior?
isActive
once scrolling is done.isActive
will be set right awayDoes this introduce a breaking change?
Other information
main
before-picker-col.mov
after-picker-col.mov
Note: Capturing an automated test for this is difficult on CI because of how quick the focus change needs to happen. I recommend testing manually at http://localhost:3333/src/components/picker-internal/test/basic on the numeric input pickers.