Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests:async: Fix Python3.12 deprecation warning #78

Closed
wants to merge 1 commit into from

Conversation

slyon
Copy link

@slyon slyon commented Nov 28, 2023

Using the old signature to throw(), Python3.12 will complain with the following DeprecationWarning:

FAILED tests/test_async_py3.py::test_func_10[normal-cext] - DeprecationWarning: the (type, exc, tb) signature of throw() is deprecated, use the single-arg signature instead.

See: https://docs.python.org/3/reference/expressions.html#generator.throw

Using the old signature to `throw()`, Python3.12 will complain with the following DeprecationWarning:

FAILED tests/test_async_py3.py::test_func_10[normal-cext] - DeprecationWarning: the (type, exc, tb) signature of throw() is deprecated, use the single-arg signature instead.

See: https://docs.python.org/3/reference/expressions.html#generator.throw
@slyon
Copy link
Author

slyon commented Nov 28, 2023

This warning should probably be visible in #76

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c56c68b) 94.84% compared to head (85893fb) 94.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   94.84%   94.51%   -0.33%     
==========================================
  Files           9        9              
  Lines        3374     3374              
  Branches      566      566              
==========================================
- Hits         3200     3189      -11     
- Misses        115      124       +9     
- Partials       59       61       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ionelmc
Copy link
Owner

ionelmc commented Dec 15, 2023

Whoops. Already done this with a bunch of other changes.

@ionelmc ionelmc closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants