Update permissions for kubectl.config.yaml #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson
reviewed
May 18, 2022
|
the reason we never saw this is because we started using ArgoCD (which we use helm template render) before the switch to helm v3, so this code was never later used with helm v3 except I think just by your project. |
Co-authored-by: Andy Thompson <me@andytson.com>
andytson
reviewed
May 18, 2022
Co-authored-by: Andy Thompson <me@andytson.com>
Chemaclass
commented
May 19, 2022
| @@ -87,7 +87,7 @@ command('app deploy <environment>'): | |||
| #!bash(harness:/helm)|= | |||
| set -o pipefail | |||
| cd "${ENVIRONMENT}" | |||
| doctl -t "$DO_ACCESS_TOKEN" kubernetes cluster kubeconfig show "$CLUSTER" > kubectl.config.yaml | |||
| (umask 0077 && doctl -t "$DO_ACCESS_TOKEN" kubernetes cluster kubeconfig show "$CLUSTER" > kubectl.config.yaml) | |||
There was a problem hiding this comment.
For the record: umask removes the bits that are allowed on a file on creation, so e.g. 0007 means if a file created with 666 permissions then it gets 660 permissions. You can see it easily with (umask 0077 && touch testfile) that it gets 600 permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After upgrading to helm 3, I faced this issue and I found a potential solution for this too: helm/helm#9115