Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pathType to Spryker webapp ingress #702

Conversation

Chemaclass
Copy link
Contributor

Description

While upgrading our project to the latest harness, I faced this error:

spec.rules[0].http.paths[0].pathType: Required value: pathType must be specified, spec.rules[0].http.paths[1].pathType: Required value: pathType must be specified

After some research, I came to this post https://pet2cattle.com/2021/04/ingress-pathtype where it seems to be missing this property:

pathType: Prefix

The question that I have now is: which of the three possible options would be the optimised for this field?

We have tree options for selecting the pathType

  • ImplementationSpecific: Matching will be handled by the IngressClass. Depending on the implementations can treat this in a different way
  • Exact: Matches the URL path exactly with case sensitivity.
  • Prefix: Matches based on a URL path prefix split by / (most common) It is also case sensitive on a path element by element basis.

@andytson-inviqa andytson-inviqa merged commit fdf164f into inviqa:1.4.x May 12, 2022
@andytson-inviqa andytson-inviqa added bug Something isn't working harness-spryker Spryker harness labels May 12, 2022
@Chemaclass Chemaclass deleted the bugfix/adding-missing-ingress-path-type branch May 12, 2022 14:11
@andytson-inviqa andytson-inviqa changed the title Add pathType to webapp ingress Add pathType to Spryker webapp ingress May 12, 2022
@andytson-inviqa
Copy link
Contributor

Prefix is how we did the other ingresses https://github.com/inviqa/harness-base-php/pull/675/files

@andytson-inviqa andytson-inviqa added this to the 1.4.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working harness-spryker Spryker harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants