Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dockerfile path with compose cli v2 #618

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Fix dockerfile path with compose cli v2 #618

merged 1 commit into from
Sep 2, 2021

Conversation

kierenevans
Copy link
Contributor

@kierenevans kierenevans commented Sep 1, 2021 •
edited
Loading

docker compose config gives path a full path to a Dockerfile, rather than a context-relative path.

We can detect this and use the dockerfile path directly.

Part of #614

@kierenevans kierenevans added enhancement New feature or request harness-php PHP harness labels Sep 1, 2021
@kierenevans kierenevans added this to the 1.2.0 milestone Sep 1, 2021
@kierenevans kierenevans merged commit 24a8ec1 into 1.2.x Sep 2, 2021
@kierenevans kierenevans deleted the 614-fix-dockerfile-path-with-compose-cli-v2 branch September 2, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgajjar hgajjar hgajjar approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request harness-php PHP harness
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kierenevans @hgajjar