Support proper booleans and discourage use of yes/no except in bash #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a841d74 to
3127cda
Compare
andytson-inviqa
commented
Jul 9, 2021
3127cda to
63cdf26
Compare
andytson-inviqa
commented
Jul 9, 2021
| @@ -1,6 +1,6 @@ | |||
| {% set tideways = @('php.ext-tideways') %} | |||
|
|
|||
| {% if tideways.enable == 'yes' %} | |||
| {% if bool(tideways.enable) %} | |||
There was a problem hiding this comment.
I'm not sure why it's erroring on this line
kierenevans
reviewed
Jul 24, 2021
63cdf26 to
8ed0d3a
Compare
8ed0d3a to
faf241f
Compare
kierenevans
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use both booleans and "yes"/"no" in Yaml, and Helm also uses the booleans