Deprecate installing harness tools in php moving upstream #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the redis-cli seems to be unreliable as well, so I'll have a think about that (perhaps, if we get it working, we put the latest redis-cli release in the upstream image if it's backwards compatible with older servers) |
c0b493b to
72d80b6
Compare
kierenevans
reviewed
Feb 11, 2021
|
Is redis-cli an issue due to using an alpine redis image with a debian-based php image? |
3c91d6a to
83848dc
Compare
kierenevans
previously approved these changes
Mar 3, 2021
and avoid repeating installation whilst deprecated
No-one's going to switch to redis debian buster version just for this, so it's better to get the one that works from the upstream version (and upgrade that)
83848dc to
dd63285
Compare
kierenevans
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and avoid repeating installation whilst deprecated