Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ingress template #546

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Clean up ingress template #546

merged 1 commit into from
Feb 3, 2021

Conversation

kierenevans
Copy link
Contributor

There was a with included in _base for easier comparisons to the spryker template.

We can move the with to later in the spryker template to avoid needing it in _base and still keep comparisons easy.

@kierenevans kierenevans added enhancement New feature or request harness-php PHP harness harness-spryker Spryker harness labels Feb 3, 2021
@kierenevans kierenevans added this to the 1.1.0 milestone Feb 3, 2021
@kierenevans kierenevans self-assigned this Feb 3, 2021
@kierenevans kierenevans enabled auto-merge (squash) February 3, 2021 11:13
@kierenevans kierenevans merged commit 60d44b1 into 1.1.x Feb 3, 2021
@kierenevans kierenevans deleted the feature/clean-up-ingress-template branch February 3, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytson-inviqa andytson-inviqa andytson-inviqa approved these changes

Assignees

@kierenevans kierenevans

Labels
enhancement New feature or request harness-php PHP harness harness-spryker Spryker harness
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kierenevans @andytson-inviqa