Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend commands not loading nvm #368

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Fix frontend commands not loading nvm #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f451a
Fix frontend commands not loading nvm
kierenevans Aug 19, 2020
179f166
Fix workdir ordering
kierenevans Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/_base/harness/config/commands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,16 @@ command('frontend watch'):
COMPOSE_PROJECT_NAME: = @('namespace')
exec: |
#!bash(workspace:/)|@
passthru docker-compose exec -u build --workdir '@('frontend.path')' console @('frontend.watch')
# Use `bash -i` to load up /home/build/.bashrc, which sets up node version manager (nvm) paths
passthru docker-compose exec -u build --workdir '@('frontend.path')' console bash -i -c '@('frontend.watch')'

command('frontend console'):
env:
COMPOSE_PROJECT_NAME: = @('namespace')
exec: |
#!bash(workspace:/)|@
passthru docker-compose exec -u build console --workdir '@('frontend.path')' bash
# Use `bash -i` to load up /home/build/.bashrc, which sets up node version manager (nvm) paths
passthru docker-compose exec -u build --workdir '@('frontend.path')' console bash -i

command('port <service>'):
env:
Expand Down
6 changes: 4 additions & 2 deletions src/spryker/harness.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,15 @@ command('frontend yves watch'):
COMPOSE_PROJECT_NAME: = @('namespace')
exec: |
#!bash(workspace:/)|@
passthru docker-compose exec -u build --workdir '@('frontend.path')' console @('frontend.yves.watch')
# Use `bash -i` to load up /home/build/.bashrc, which sets up node version manager (nvm) paths
passthru docker-compose exec -u build --workdir '@('frontend.path')' console bash -i -c '@('frontend.yves.watch')'
command('frontend zed watch'):
env:
COMPOSE_PROJECT_NAME: = @('namespace')
exec: |
#!bash(workspace:/)|@
passthru docker-compose exec -u build --workdir '@('frontend.path')' console @('frontend.zed.watch')
# Use `bash -i` to load up /home/build/.bashrc, which sets up node version manager (nvm) paths
passthru docker-compose exec -u build --workdir '@('frontend.path')' console bash -i -c '@('frontend.zed.watch')'
---
import:
- harness/config/*.yml
Expand Down