Fix multiple argument run/passthru escaping and migrate most to use it #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andytson-inviqa
commented
Aug 5, 2020
- Multiple argument run/passthru was splitting arguments with spaces in, and losing empty arguments
- Some still use single argument run/passthru due to use of shell, but may be dealt with later
* Multiple argument run/passthru was splitting arguments with spaces in, and losing empty arguments * Some still use single argument run/passthru due to use of shell, but may be dealt with later
andytson-inviqa
commented
Aug 5, 2020
as unnecessary complexity in capturing one of two possible commands in one execution
There is shell code in it
To match use of run and passthru
andytson-inviqa
commented
Aug 5, 2020
Co-authored-by: Kieren Evans <kierenevans@users.noreply.github.com>
kierenevans
reviewed
Aug 11, 2020
src/spryker/docker/image/console/root/lib/task/skeleton/apply.sh.twig
Outdated
Show resolved
Hide resolved
src/spryker/docker/image/console/root/lib/task/spryker/install.sh
Outdated
Show resolved
Hide resolved
Co-authored-by: Kieren Evans <kierenevans@users.noreply.github.com>
andytson-inviqa
commented
Aug 11, 2020
kierenevans
added a commit
that referenced
this pull request
Aug 11, 2020
kierenevans
reviewed
Aug 11, 2020
kierenevans
reviewed
Aug 11, 2020
kierenevans
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.