Support image pull configuration using sealed-secrets #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andytson-inviqa
commented
Jul 20, 2020
•
- also rename docker.config as by itself sounds benign non-sensitive information and doesn't explain purpose
- sealed config will be the default due to security requirements
- as is a new CRD, add additional schema location
3a55e1c to
5338746
Compare
32fd0c5 to
7806512
Compare
3bb2f06 to
e3574ef
Compare
* also rename docker.config as by itself sounds benign non-sensitive information and doesn't explain purpose * sealed config will be the default due to security requirements
It's going to be used elsewhere as well as docker credentials
8a77088 to
bd03219
Compare
kierenevans
previously approved these changes
Jul 29, 2020
kierenevans
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.