Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SensioLabs Behat PageObjectExtension to Magento 2 skeleton #264

Merged
merged 2 commits into from
Apr 4, 2020
Merged

Add SensioLabs Behat PageObjectExtension to Magento 2 skeleton #264

merged 2 commits into from
Apr 4, 2020

Conversation

tkotosz
Copy link

@tkotosz tkotosz commented Apr 4, 2020 •
edited
Loading

Changelog:

  • Add back previously removed BehatPageObjectExtension: It is used on some projects so it seems it is still good to have it.
  • Upgrade BehatMagento2Extension: A new version was released to support the BehatPageObjectExtension see here which is needed to be able to use all features of the BehatPageObjectExtension.
  • Add example to demonstrate how to use chrome when doing a web based test: See homepage.feature @javascript tagged scenario.
  • Add example to demonstrate how to use the constructor injection feature of the BehatPageObjectExtension. See the web_with_page_objects_first behat suite.
  • Add example to demonstrate how to use the page object factory injection feature of the BehatPageObjectExtension. See the web_with_page_objects_second behat suite.

@coledave coledave added the harness-magento2 Magento 2.x harness label Apr 4, 2020
@coledave coledave added this to the 0.6.0 milestone Apr 4, 2020
@coledave coledave merged commit 2a0f093 into 0.6.x Apr 4, 2020
@coledave coledave deleted the feature/add-behat-page-object-extension-to-m2-skeleton branch April 4, 2020 10:46
szagabesz
szagabesz reviewed Apr 6, 2020
View reviewed changes
Copy link

@szagabesz szagabesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kierenevans kierenevans added the enhancement New feature or request label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szagabesz szagabesz szagabesz left review comments

Assignees
No one assigned
Labels
enhancement New feature or request harness-magento2 Magento 2.x harness
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tkotosz @szagabesz @kierenevans @coledave