fix(storage, ios): do not enumerate on dictionary being mutated

[danielhover]

Description

Noticed crashes originating from RNFBStorage regarding Collection <__NSDictionaryM: XXXXXXX> was mutated while being enumerated.. This appears to be addressed in some of the other packages already.

Related issues

#3736

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• This is a breaking change;
  • Yes
  • No

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/JCiDdtLxrKR5Td4HBbu3gBkNtiph
✅ Preview: https://react-native-firebase-git-fork-hoverinc-fix-st-b46756-invertase.vercel.app

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #5455 (72b5f36) into master (0d26af9) will not change coverage.
The diff coverage is n/a.

❗ Current head 72b5f36 differs from pull request most recent head 6819dde. Consider uploading reports for the commit 6819dde to get more accurate results

@@           Coverage Diff           @@
##           master    #5455   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files          96       96           
  Lines        4287     4287           
  Branches      921      921           
=======================================
  Hits         3196     3196           
  Misses       1021     1021           
  Partials       70       70           

[mikehardy]

Nice catch! Yes this the same as a couple other areas that had the issue, as you correctly linked. I grepped through the whole code base, since this is obviously a recurring bug and after verifying all the other dealloc cases I think you've found and fixed the last one.

Thank you!

[mikehardy]

I'm working on a release now but want to fix one other issue first. That means this should be released shortly but in case you want it immediately one of the checks that runs on the PR generates a patch-package .zip which you may download and integrate into your project easily without regard to any possible delay here. Cheers!

[genintho]

@mikehardy Thank you for the quick review, your very thoughtful answer!