Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e, emulator): correctly handle exit in non-ci environments #5336

Merged
merged 1 commit into from
May 19, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

Last script edit was perfect for CI but did not get the non-CI case correct, so it would re-spawn after exit

Now in non-CI environments it will correctly exit when the emulator is done

Related issues

Original commit was in PR #5335

Release Summary

conventional commit

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/BajJV4BUBQyrdDNPhWLhhjP7eanr
✅ Preview: In Progress

@mikehardy mikehardy merged commit 95cdec6 into master May 19, 2021
@mikehardy mikehardy deleted the @mikehardy/fix-emulator-non-ci-start branch May 19, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant