-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): support storage.useEmulator, and md5hash metadata on upload #5324
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/BBTfbY8Uu6KGNKKnF8NofJwKpbWD |
Codecov Report
@@ Coverage Diff @@
## master #5324 +/- ##
============================================
+ Coverage 68.38% 74.56% +6.18%
============================================
Files 189 97 -92
Lines 9449 4288 -5161
Branches 1411 921 -490
============================================
- Hits 6461 3197 -3264
+ Misses 2569 1021 -1548
+ Partials 419 70 -349 |
@Salakar not sure what's going on with iOS, it seems like such a simple call but then when you go to fetch references and do things, it tries to go to live storage. Does it need to be more like functions where at the javascript level we keep track of the emulator host/port and rewrite everything between gs:// and the bucket name before sending it native? |
437cc2f
to
b04718a
Compare
b04718a
to
ecb6aee
Compare
…roid 10/11 compat On Android the following paths exist in app.utils.paths but are inaccessible without special permission: 'EXTERNAL_DIRECTORY', 'EXTERNAL_STORAGE_DIRECTORY', 'PICTURES_DIRECTORY', 'MOVIES_DIRECTORY', Please follow Google's migration guides for "Scoped Storage" to store your data in a future compatible way. https://developer.android.com/about/versions/11/privacy/storage#scoped-storage BREAKING CHANGE: if you need READ_EXTERNAL_STORAGE/WRITE_EXTERNAL_STORAGE permission add them in your app AndroidManifest.xml
metadata property md5hash is allowed for upload, just not for updateMetadata allow it to go through in the putNNN scenarios but screen for it on update
ecb6aee
to
b6f6fae
Compare
Description
Each commit has it's own informative title and notes
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Turn off your network and run e2e tests with the storage emulator running or
turn off the emulator and try to run e2e tests
Right now those show Android and iOS is using the emulator and it's all working
There are a few platform-specific issues marked FIXME, that need followup with firebase repos
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter