test(Podfile): use firestore-ios-framework version vs master #4640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test podfile was pointing at master, but that can cause problems if the newest ios release is different then the one under test. They must be the same, so use the tag on firebase-ios-sdk-frameworks at the specified version vs master
Noticed while developing #4471 as it caused test app compile errors during baseline as master was 7.0.0 while I was still on 6.x.x originally
Release Summary
named with conventional commit
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
It actually is a test, so the test app either compiles or it doesn't, but with this change it will compile reliably
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter