Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Podfile): use firestore-ios-framework version vs master #4640

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

mikehardy
Copy link
Collaborator

Description

The test podfile was pointing at master, but that can cause problems if the newest ios release is different then the one under test. They must be the same, so use the tag on firebase-ios-sdk-frameworks at the specified version vs master

Noticed while developing #4471 as it caused test app compile errors during baseline as master was 7.0.0 while I was still on 6.x.x originally

Release Summary

named with conventional commit

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

It actually is a test, so the test app either compiles or it doesn't, but with this change it will compile reliably


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Dec 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/j6i8dc1tz
✅ Preview: https://react-native-fireb-git-mikehardy-test-podfile-use-specif-aefacb.invertase.vercel.app

@mikehardy mikehardy added tools: ci Type: Testing Issues or PRs relating to testing (the library or user code testing) Workflow: Pending Merge Waiting on CI or similar labels Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #4640 (000a7dd) into master (e7688e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4640   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files         109      109           
  Lines        3712     3712           
  Branches      347      347           
=======================================
  Hits         3301     3301           
  Misses        369      369           
  Partials       42       42           

@mikehardy mikehardy merged commit a96a401 into master Dec 2, 2020
@mikehardy mikehardy deleted the @mikehardy/test-podfile-use-specified-sdk branch December 2, 2020 23:39
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools: ci Type: Testing Issues or PRs relating to testing (the library or user code testing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant