Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admob, ios): add adaptive banner support #4565

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

dylancom
Copy link
Contributor

Description

This pull request adds support for adaptive banners. #4276

Release Summary

Added adaptive banner support for iOS.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

@vercel
Copy link

vercel bot commented Nov 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/pvqlz4e1f
✅ Preview: https://react-native-firebase-git-master.invertase.vercel.app

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #4565 (4ce43e4) into master (513c345) will increase coverage by 39.09%.
The diff coverage is 88.00%.

@@             Coverage Diff             @@
##           master    #4565       +/-   ##
===========================================
+ Coverage   41.92%   81.00%   +39.09%     
===========================================
  Files          35      109       +74     
  Lines        1119     3710     +2591     
  Branches      278      346       +68     
===========================================
+ Hits          469     3005     +2536     
- Misses        489      657      +168     
+ Partials      161       48      -113     

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for this! Looks like a typo and maybe could use a note for iOS only, but otherwise if you have tested this (specifically the CFGloat / size calculations) and it works, that works for me

packages/admob/lib/index.d.ts Outdated Show resolved Hide resolved
packages/admob/lib/index.d.ts Show resolved Hide resolved
@mikehardy mikehardy changed the title Add adaptive banner support feat(admob, ios): add adaptive banner support Nov 17, 2020
@mikehardy mikehardy added Workflow: Waiting for User Response Blocked waiting for user response. plugin: admob Google AdMob type: enhancement Implements a new Feature labels Nov 17, 2020
@dylancom
Copy link
Contributor Author

Hey thanks for this! Looks like a typo and maybe could use a note for iOS only, but otherwise if you have tested this (specifically the CFGloat / size calculations) and it works, that works for me

I have tested it and it works. I will fix the typo and add an iOS note. In the future I will probably have time to also add Android support.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!
Until release, you can go to the "patch packages" action and find a zip file with the patch you can apply locally (using the always amazing https://github.com/ds300/patch-package). I mention that because I just did a couple of very big releases and I want those to marinate for a bit before I do another one

@mikehardy mikehardy merged commit ce8ac1a into invertase:master Nov 17, 2020
@mikehardy mikehardy removed the Workflow: Waiting for User Response Blocked waiting for user response. label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: admob Google AdMob type: enhancement Implements a new Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants