-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admob, ios): add adaptive banner support #4565
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/pvqlz4e1f |
Codecov Report
@@ Coverage Diff @@
## master #4565 +/- ##
===========================================
+ Coverage 41.92% 81.00% +39.09%
===========================================
Files 35 109 +74
Lines 1119 3710 +2591
Branches 278 346 +68
===========================================
+ Hits 469 3005 +2536
- Misses 489 657 +168
+ Partials 161 48 -113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for this! Looks like a typo and maybe could use a note for iOS only, but otherwise if you have tested this (specifically the CFGloat / size calculations) and it works, that works for me
I have tested it and it works. I will fix the typo and add an iOS note. In the future I will probably have time to also add Android support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
Until release, you can go to the "patch packages" action and find a zip file with the patch you can apply locally (using the always amazing https://github.com/ds300/patch-package). I mention that because I just did a couple of very big releases and I want those to marinate for a bit before I do another one
Description
This pull request adds support for adaptive banners. #4276
Release Summary
Added adaptive banner support for iOS.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__