Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app,ios): Build fails when targeting Mac (Project Catalyst) #3840

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

andymatuschak
Copy link
Contributor

Description

The Catalyst SDK does not support assets-library:// URLs (see #2698), which have been deprecated for many years. This patch fixes the build failure when compiling with the Catalyst SDK; requests for such assets will fail and log (the first time).

Related issues

Fixes #2698

Release Summary

Fixes compilation failures when targeting macOS Catalyst.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  1. Initialize a new React Native app with react-native init
  2. Integrate @react-native-firebase/app
  3. Check the "macOS" platform box in Xcode to add Catalyst support.
  4. Build for macOS.

🔥

The Catalyst SDK does not support `assets-library://` URLs, which have been deprecated for many years. This patch fixes the build failure when compiling with the Catalyst SDK; requests for such assets will fail and log (the first time).
@CLAassistant
Copy link

CLAassistant commented Jun 26, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pretty reasonable fix with good developer instruction, LGTM
@Salakar ?

@mikehardy mikehardy requested a review from Salakar June 26, 2020 03:14
@Salakar Salakar merged commit 13bc6a7 into invertase:master Jun 26, 2020
@Salakar
Copy link
Contributor

Salakar commented Jun 26, 2020

Thank you, LGTM, merged, a release will be up shortly once CI finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails when targeting Mac (Project Catalyst)
4 participants