build(e2e, ios): reinstate xcpretty, with correct compile failure sta…

…tus report

previously there was an issue with combination of xcpretty and CI, such that
compile failures were not detected and failing CI. I believe this combo of
set -o pipefail and xcpretty should do it. It passes local negative- and
positive-testing on build status reporting

.github/workflows/tests_e2e_ios.yml

@@ -92,7 +92,7 @@ jobs:
           timeout_minutes: 2
           retry_wait_seconds: 60
           max_attempts: 3
-          command: gem update cocoapods xcodeproj
+          command: gem update cocoapods xcodeproj xcpretty
 
       - uses: actions/cache@v2
         name: Cache Pods

tests/package.json

@@ -58,15 +58,15 @@
     "configurations": {
       "ios.sim.debug": {
         "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/testing.app",
-        "build": "xcodebuild VALID_ARCHS=\"`uname -m`\"  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build",
+        "build": "set -o pipefail && xcodebuild VALID_ARCHS=\"`uname -m`\"  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build | xcpretty",
         "type": "ios.simulator",
         "device": {
           "type": "iPhone 11"
         }
       },
       "ios.sim.release": {
         "binaryPath": "ios/build/Build/Products/Release-iphonesimulator/testing.app",
-        "build": "export RCT_NO_LAUNCH_PACKAGER=true && xcodebuild  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Release -sdk iphonesimulator -derivedDataPath ios/build",
+        "build": "export RCT_NO_LAUNCH_PACKAGER=true && set -o pipefail && xcodebuild  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Release -sdk iphonesimulator -derivedDataPath ios/build | xcpretty",
         "type": "ios.simulator",
         "device": {
           "type": "iPhone 11"