fix(android): specify that android services are not exported

Additionally, app is directBootAware - this mirrors upstream definition: https://github.com/firebase/firebase-android-sdk/blob/ad135d8c3c1243b4c673e17bc032ee1052fb2a22/firebase-common/src/main/AndroidManifest.xml#L10-L12
invertase · Jun 17, 2022 · 39e0444 · 39e0444 · vercel · Jun 17, 2022
1 parent 3cb1d0a
commit 39e0444
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/app/android/src/main/AndroidManifest.xml b/packages/app/android/src/main/AndroidManifest.xml
@@ -1,10 +1,16 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
+  xmlns:tools="http://schemas.android.com/tools"
   package="io.invertase.firebase">
 
   <application>
     <meta-data android:name="app_data_collection_default_enabled" android:value="${firebaseJsonDataCollectionDefaultEnabled}"/>
-    <service android:name="com.google.firebase.components.ComponentDiscoveryService">
+    <service
+      android:name="com.google.firebase.components.ComponentDiscoveryService"
+      android:directBootAware="true"
+      android:exported="false"
+      tools:targetApi="n"
+    >
       <meta-data
         android:name="com.google.firebase.components:io.invertase.firebase.app.ReactNativeFirebaseAppRegistrar"
         android:value="com.google.firebase.components.ComponentRegistrar" />

diff --git a/packages/messaging/android/src/main/AndroidManifest.xml b/packages/messaging/android/src/main/AndroidManifest.xml
@@ -7,7 +7,8 @@
   <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
 
   <application>
-    <service android:name=".ReactNativeFirebaseMessagingHeadlessService" />
+    <service android:name=".ReactNativeFirebaseMessagingHeadlessService"
+              android:exported="false" />
     <service android:name=".ReactNativeFirebaseMessagingService"
              android:exported="false">
       <intent-filter>