fix(app-check, activate): return Promise(void) on ios not void

previously iOS was not returning a promise, but Android was, documentation was for a Promise to be returned Fixes #6052 - Thanks to @birdofpreyru
invertase · Feb 7, 2022 · 0f23441 · 0f23441
1 parent 65cac09
commit 0f23441
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/packages/app-check/e2e/appcheck.e2e.js b/packages/app-check/e2e/appcheck.e2e.js
@@ -65,12 +65,12 @@ describe('appCheck()', function () {
     });
   });
   describe('activate())', function () {
-    it('should activate with default provider and default token refresh', async function () {
-      try {
-        await firebase.appCheck().activate('ignored', false);
-      } catch (e) {
-        return Promise.reject(e);
-      }
+    it('should activate with default provider and default token refresh', function () {
+      firebase
+        .appCheck()
+        .activate('ignored', false)
+        .then(value => expect(value).toBe(undefined))
+        .catch(e => new Error('app-check activate failed? ' + e));
     });
   });
 });
diff --git a/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckModule.m b/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckModule.m
@@ -39,7 +39,9 @@ - (dispatch_queue_t)methodQueue {
 RCT_EXPORT_METHOD(activate
                   : (FIRApp *)firebaseApp
                   : (nonnull NSString *)siteKeyOrProvider
-                  : (BOOL)isTokenAutoRefreshEnabled) {
+                  : (BOOL)isTokenAutoRefreshEnabled
+                  : (RCTPromiseResolveBlock)resolve rejecter
+                  : (RCTPromiseRejectBlock)reject) {
   // From SDK docs:
   // NOTE: Make sure to call this method before FirebaseApp.configure().
   // If this method is called after configuring Firebase, the changes will not take effect.
@@ -49,6 +51,7 @@ - (dispatch_queue_t)methodQueue {
 
   FIRAppCheck *appCheck = [FIRAppCheck appCheckWithApp:firebaseApp];
   appCheck.isTokenAutoRefreshEnabled = isTokenAutoRefreshEnabled;
+  resolve([NSNull null]);
 }
 
 RCT_EXPORT_METHOD(setTokenAutoRefreshEnabled