feat(ios): handle response events for remote notifications [next]

[helenaford]

@next release 5.0.0-0
So far includes the following events for remote notifications:

• PRESSED
• ACTION_PRESSED
• DISMISSED

Release Notes:

• [BREAKING] On iOS, onNotificationOpenedApp and getInitialNotification from RNFB Messaging will no longer trigger as notifee will handle the event.
• [feat] Can support quick actions from remote notifications without need of a NSE

[codecov]

Codecov Report

Merging #236 (92f168b) into main (892cab9) will not change coverage.
The diff coverage is n/a.

❗ Current head 92f168b differs from pull request most recent head 36acf66. Consider uploading reports for the commit 36acf66 to get more accurate results

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   77.33%   77.33%           
=======================================
  Files          32       32           
  Lines        1658     1658           
  Branches      533      553   +20     
=======================================
  Hits         1282     1282           
+ Misses        375      328   -47     
- Partials        1       48   +47     

[zenshayan]

Hi, iOS quick actions from remote notifications without need of a NSE works perfectly well. However, foreground notifications on iOS no longer work

[johnf]

@helenaford is this PR still relevant?

I'm trying to get PRESS events from remote notifications on iOS. Is this PR something to try or is it because I fon't have an NSE?

[helenaford]

@johnf Yes, it is.

I've updated this branch with the latest changes and have published it as a @next release (v6.0.0-0).

[finalight]

when can we have this feature?

because on iOS, we can't receive click event, unless there's other ways for now?

[johnf]

@helenaford I can confirm that I've tested this and it works as expected.
Rolling It out to production a bit later this week for broader testing

[ice-cap0]

This PR is amazing, along with #229 looks like there's a whole bunch of Notifee caveats for iOS being deprecated 🎉
Awesome stuff guys and gals, thanks for the ongoing development, this is the real deal
patiently waits for the drop

[MEsteves22]

Hello,

First, I would like to thank you for your work and this amazing library!

I've upgraded Notifee to version 7.0.4, and I'm having some trouble understanding how I'm able to get which notification has caused my application to open when it was quit/closed. Previously, I was using onNotificationOpenedApp and getInitialNotification from RNFB to execute some code after the app opens when the user clicks on a notification. However, these events no longer work on iOS as mentioned in the release notes.

I've followed this tutorial (https://notifee.app/react-native/docs/ios/remote-notification-support), set up NSE (which I was already using to attach an image) and I'm receiving my notifications. However, when I click on a notification when the app is quit, the onForegroundEvent from Notifee is never called. It's only called when the app is in the foreground or background. The getInitialNotification event from Notifee is called but the documentation is saying that "getInitialNotification is deprecated on iOS in favour of the PRESS event received by the onForegroundEvent event handler".

I don't know if I'm misunderstanding the documentation or if I'm missing something.

Thank you!

[billnbell]

It says you don't need NSE... This allows quick actions from remote notifications to be supported without the need of a NSE... But we need more documentation

[venux92]

@MEsteves22

This is my actual setup on 7.1.0

notifee.onForegroundEvent(async ({ type, detail }) => {
    switch (type) {
        case EventType.PRESS:
           await this.handleNotification(detail)
           break
        case EventType.ACTION_PRESS:
           await this.handleAction(detail)
           break
}})

And it works fine for me on iOS, I just switched from 5.5.0 to 7.1.0 but I was already using it that way with 5.5.0

I still use a NSE as well for my notification image

Hopefully this helps you

[MEsteves22]

@venux92 Thank you for your help 🙏

[Minishlink]

FYI it looks like there is a conflict with the Braze SDK with this line
To reproduce : install notifee and braze. Open your app, send a Braze test IAM campaign, click on the notification to show the IAM. No IAM is shown.
And possibly conflicts with other SDKs

[Minishlink]

Workaround is patching parseUNNotificationRequest with

+  if (userInfo != nil && userInfo[keyToExclude] != nil) {
+      return nil;
+  }

[mikehardy]

Oh no! Looks like an easy enough local patch-package fix for you (I'd bet $1 you already have that running ;-) ) but a PR here is something we could integrate