Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements #505 #512

Merged
merged 2 commits into from
Mar 22, 2017
Merged

Implements #505 #512

merged 2 commits into from
Mar 22, 2017

Conversation

remojansen
Copy link
Member

@remojansen remojansen commented Mar 22, 2017 •
edited
Loading

Description

Implements #505

Related Issue

#505

Motivation and Context

#505

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@remojansen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jamesrichford, @lukas-zech-software and @sanex3339 to be potential reviewers.

@remojansen remojansen mentioned this pull request Mar 22, 2017
Closed
@remojansen remojansen merged commit be1c2fc into master Mar 22, 2017
@remojansen remojansen deleted the issue-505 branch March 22, 2017 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remojansen @mention-bot