Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method Base.diff(nda::NamedDimsArray; dims) closes #195 #209

Merged
merged 6 commits into from
Oct 24, 2022

Conversation

mjp98
Copy link
Member

@mjp98 mjp98 commented Oct 24, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #209 (96cb6a6) into master (5d66834) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   94.74%   94.76%   +0.02%     
==========================================
  Files          14       14              
  Lines         685      688       +3     
==========================================
+ Hits          649      652       +3     
  Misses         36       36              
Impacted Files Coverage Δ
src/functions_math.jl 97.10% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

test/functions_math.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@glennmoy glennmoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also bump the version in the Project.toml to 1.2.0

test/functions_math.jl Outdated Show resolved Hide resolved
mjp98 and others added 2 commits October 24, 2022 14:10
Co-authored-by: Glenn Moynihan <glenn.moynihan@invenialabs.co.uk>
@mjp98
Copy link
Member Author

mjp98 commented Oct 24, 2022

Closes #195

@mjp98 mjp98 merged commit a016422 into master Oct 24, 2022
@mjp98 mjp98 deleted the mjp/define-diff-method branch October 24, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants