Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0 ? #204

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Release 1.0 ? #204

merged 2 commits into from
Aug 11, 2022

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Aug 5, 2022

This is pretty much stable.
This release will be nonbreaking and the same as the last 0.3.x release which is frustrating but still better I think than leaving this 0.x forever.

Though maybe this isn't as stable as i thought, why did we release 0.3?

Invenia's new internal policy is to create packages at 1.0.0 and never use 0.x.y versioning

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #204 (f4abaa6) into master (712a901) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files          14       14           
  Lines         673      673           
=======================================
  Hits          638      638           
  Misses         35       35           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mzgubic
Copy link
Collaborator

mzgubic commented Aug 5, 2022

https://github.com/invenia/NamedDims.jl/pull/202/files#r937572855

we dropped support for Julia 1.5 and below. Is that in line with SemVer?

@oxinabox
Copy link
Member Author

oxinabox commented Aug 5, 2022

😬
Dropping julia compatibility basically never can be considered breaking by SemVer.
Because Pkg will prevent anything not compatible with this version of julia from ever installing.

Convention for packages that are post v1.0.0 is to use a minor release so that patch releases can squeeze in any backports easily. ( and that is enforced at the registry CI IIRC)
Pre v1.0.0 it is just another nonbreaking release.

@oxinabox oxinabox merged commit b8b745c into master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants