Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement ProjectTo for NamedDimsArray #201

Merged
merged 4 commits into from
Aug 5, 2022
Merged

implement ProjectTo for NamedDimsArray #201

merged 4 commits into from
Aug 5, 2022

Conversation

mzgubic
Copy link
Collaborator

@mzgubic mzgubic commented Aug 1, 2022

Closes #200

@oxinabox
Copy link
Member

oxinabox commented Aug 1, 2022

The requirements for this are.

  • Projecting conflicting names throws an error
  • projecting unnamed trangent (which is an abstract array) onto named primal gets primals name
  • projecting partially unnamed tangent onto fully named primal gets primal name
  • projecting fully named tangent onto partially named primal gets fully named
  • projecting (:_, :B) onto (:A, _) gets (:A, :B)

I would like to see these in the tests

@mzgubic
Copy link
Collaborator Author

mzgubic commented Aug 1, 2022

Ah, good catch. I copied it over from AxisKeys which is similarly cavalier about it, will open an issue there to track it.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #201 (e22cfdc) into master (712a901) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   94.79%   94.84%   +0.04%     
==========================================
  Files          14       14              
  Lines         673      679       +6     
==========================================
+ Hits          638      644       +6     
  Misses         35       35              
Impacted Files Coverage Δ
src/chainrules.jl 92.85% <100.00%> (+5.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mzgubic mzgubic requested a review from oxinabox August 2, 2022 13:22
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is good

@mzgubic mzgubic merged commit 2aea7bd into master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProjectTo is not defined for NamedDimsArray
2 participants