adjoint/transpose multiplication (#199)

invenia · Jul 8, 2022 · f803d70 · f803d70 · mzgubic · Jul 8, 2022
1 parent 368944f
commit f803d70
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "NamedDims"
 uuid = "356022a1-0364-5f58-8944-0da4b18d706f"
 authors = ["Invenia Technical Computing Corporation"]
-version = "0.2.48"
+version = "0.2.49"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

diff --git a/src/functions_math.jl b/src/functions_math.jl
@@ -52,8 +52,10 @@ end
 # Using `CoVector` results in Method ambiguities; have to define more specific methods.
 for A in (
     Adjoint{<:Number,<:AbstractVector},
+    Adjoint{<:Any,<:AbstractVector}, # https://github.com/invenia/NamedDims.jl/issues/198
+    Transpose{<:Any,<:AbstractVector}, # https://github.com/invenia/NamedDims.jl/issues/198
     Transpose{<:Real,<:AbstractVector{<:Real}},
-    Transpose{<:Any, <:AbstractMatrix{T}} where T,  # resolves ambiguity error in AxisKeys
+    Transpose{<:Any,<:AbstractMatrix{T}} where {T},  # resolves ambiguity error in AxisKeys
 )
     @eval function Base.:*(a::$A, b::NamedDimsArray{L,T,1,<:AbstractVector{T}}) where {L,T}
         return *(a, parent(b))

diff --git a/test/functions_math.jl b/test/functions_math.jl
@@ -150,6 +150,8 @@ end
         @test ndv' * ndv == adjoint(v) * ndv == transpose(v) * ndv
         @test ndv * v' == ndv * adjoint(v) == ndv * transpose(v)
         @test ndv * ndv' == [1 2 3; 2 4 6; 3 6 9]
+        VERSION >= v"1.5" && @test adjoint([missing, missing, missing]) * ndv isa Missing # https://github.com/invenia/NamedDims.jl/issues/198
+        @test transpose([missing, missing, missing]) * ndv isa Missing # https://github.com/invenia/NamedDims.jl/issues/198
 
         ndv2 = NamedDimsArray{(:b,)}([3, 2, 1])
         @test_throws DimensionMismatch ndv' * ndv2