Mark allocation tests broken in julia 1.4 (#117)

* mark tests broken * link to issue * fix using SparseArrays
invenia · Jul 17, 2020 · 56055d7 · 56055d7
1 parent d735031
commit 56055d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1,5 +1,6 @@
 using NamedDims
 using BenchmarkTools
+using SparseArrays
 using Test
 
 const testfiles = (

diff --git a/test/wrapper_array.jl b/test/wrapper_array.jl
@@ -231,10 +231,14 @@ const cnda = NamedDimsArray([10 20; 30 40], (:x, :y))
     @test 0 == @ballocated dimnames(cnda)
 
     # These tests use `@allocated` as for some reason `@ballocated` reports 1 alloc
-    @test 0 == @allocated NamedDimsArray(cnda, (:x, :y))
-    if VERSION >= v"1.1"
+    if VERSION >= v"1.4" # see https://github.com/invenia/NamedDims.jl/issues/115
+        @test_broken 0 == @allocated NamedDimsArray(cnda, (:x, :y))
+        @test_broken 0 == @allocated NamedDimsArray(cnda, (:x, :_))
+    elseif VERSION >= v"1.1"
+        @test 0 == @allocated NamedDimsArray(cnda, (:x, :y))
         @test 0 == @allocated NamedDimsArray(cnda, (:x, :_))
     else
+        @test 0 == @allocated NamedDimsArray(cnda, (:x, :y))
         @test_broken 0 == @allocated NamedDimsArray(cnda, (:x, :_))
     end