-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify tests for Date/DateTime repr changes #64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 97.89% 91.21% -6.68%
==========================================
Files 6 6
Lines 237 239 +2
==========================================
- Hits 232 218 -14
- Misses 5 21 +16
Continue to review full report at Codecov.
|
83b1a30
to
77cd499
Compare
Looks like all that is left is to drop Julia 0.6 from the CI files and from the REQUIRE. Please combine the existing commits before you add that commit. |
Would I also change |
- In Julia v"1.2.0-DEV.29" Date and DateTime repr changed from "yyyy-mm-dd" to "Date(yyyy, m, d)", and similarly with DateTime. This changed that comes out of show, so the tests that check the output string of Intervals with Dates and DateTimes had to be changed to follow suit.
3c203b0
to
cd87777
Compare
Not too sure why some of the tests are failing with |
I think you can change the "docs/make.jl" to use 1.0.
In the build step the tzdata failed to download. |
12055ff
to
6db1ae7
Compare
In Julia v"1.2.0-DEV.29" Date and DateTime repr changed from
"yyyy-mm-dd" to "Date(yyyy, m, d)", and similarly with DateTime. This
changed that comes out of show, so the tests that check the output
string of Intervals with Dates and DateTimes had to be changed to follow
suit.
Closes #59