Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with (x; y=0) -> ... pattern #9

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

pablosanjose
Copy link
Contributor

Closes #8

Before this PR, the kwarg y=0 in splitdef((x; y=0) -> ...) was being injected as :(y=0) instead of Expr(:kw, y, 0) into the Dict. This fix is done via special-casing this pattern.

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #9 into master will increase coverage by 1.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   94.93%   96.29%   +1.35%     
==========================================
  Files           2        2              
  Lines          79       81       +2     
==========================================
+ Hits           75       78       +3     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
src/function.jl 96.25% <100.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ecb56a...b0ab5d1. Read the comment docs.

@oxinabox
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

combinedef bug with a single kwarg with default value
2 participants