Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitdef: handle invalid Expr(:function, :(f(x))) #31

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

rfourquet
Copy link
Contributor

This would previously result in :name => :(f(x)).

This would previously result in `:name => :(f(x))`.
@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #31 (d59b379) into master (55d91f5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files           5        5           
  Lines         217      217           
=======================================
  Hits          212      212           
  Misses          5        5           
Impacted Files Coverage Δ
src/function.jl 98.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d91f5...d59b379. Read the comment docs.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oxinabox
Copy link
Member

CI on Julia 1 is unrelated #32

@oxinabox oxinabox merged commit f74f61a into invenia:master Jan 11, 2022
@rfourquet rfourquet deleted the fix-empty-functions branch February 26, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants