Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extra hygiene for signature(::Methood) #25

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Jul 6, 2021

This is adding the extra-hygiene feature from #18
It is the thing to work around JuliaLang/julia#39876

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #25 (7e2b13a) into master (3d15ed4) will decrease coverage by 0.90%.
The diff coverage is 100.00%.

❗ Current head 7e2b13a differs from pull request most recent head 4fb5aab. Consider uploading reports for the commit 4fb5aab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   98.60%   97.69%   -0.91%     
==========================================
  Files           5        5              
  Lines         215      217       +2     
==========================================
  Hits          212      212              
- Misses          3        5       +2     
Impacted Files Coverage Δ
src/method.jl 97.22% <100.00%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d15ed4...4fb5aab. Read the comment docs.

Copy link
Contributor

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, was this not added in #18? It sure looks like it was in the PR

Copy link
Contributor

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs version bump

Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
@oxinabox oxinabox merged commit b7f6cc0 into master Jul 6, 2021
@oxinabox oxinabox deleted the ox/extrahygine branch July 6, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants