Allow callable structs in argument_names #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 98.61% 98.60% -0.01%
==========================================
Files 5 5
Lines 216 215 -1
==========================================
- Hits 213 212 -1
Misses 3 3
Continue to review full report at Codecov.
|
|
Hmm, looks like that test is too fragile. |
oxinabox
reviewed
Jul 5, 2021
oxinabox
reviewed
Jul 5, 2021
oxinabox
reviewed
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
In the future, we could add full support for callable structs by allowing the user to specify whether or not to include the first argument name/type in the output of
signature. I'm not sure that we want to do it automatically because 1) this would introduce inconsistency into the behavior and 2) excluding the function object name/type is probably the most common use case. In fact, one would (I think) always need to have an instance of the struct available in order to obtain the corresponding method anyway, so it's probably redundant.