Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arg_tuple_expr #17

Merged
merged 3 commits into from
Jul 1, 2021
Merged

add arg_tuple_expr #17

merged 3 commits into from
Jul 1, 2021

Conversation

oxinabox
Copy link
Member

This is useful to have and something that is needed for Nabla invenia/Nabla.jl#189
(It is extracted out of that PR)

Copy link
Contributor

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was going to complain it doesn't deal with kwargs, but that seems by design (and maybe addressed by other PRs, haven't yet checked)

only one real comment, the rest is just fixing typos

@oxinabox
Copy link
Member Author

oxinabox commented Jul 1, 2021

i was going to complain it doesn't deal with kwargs, but that seems by design

This is by design, kwargs are not a feature I need right now.
I will add to the docstring that it only does positional arguments

Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #17 (3c00805) into master (6063438) will decrease coverage by 0.44%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   99.42%   98.97%   -0.45%     
==========================================
  Files           4        5       +1     
  Lines         174      196      +22     
==========================================
+ Hits          173      194      +21     
- Misses          1        2       +1     
Impacted Files Coverage Δ
src/ExprTools.jl 100.00% <ø> (ø)
src/def_tools.jl 95.45% <95.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6063438...3c00805. Read the comment docs.

@oxinabox oxinabox merged commit 30c1a58 into master Jul 1, 2021
@oxinabox oxinabox deleted the ox/args_tuple_expr branch July 1, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants