-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add arg_tuple_expr #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was going to complain it doesn't deal with kwargs, but that seems by design (and maybe addressed by other PRs, haven't yet checked)
only one real comment, the rest is just fixing typos
This is by design, kwargs are not a feature I need right now. |
Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 99.42% 98.97% -0.45%
==========================================
Files 4 5 +1
Lines 174 196 +22
==========================================
+ Hits 173 194 +21
- Misses 1 2 +1
Continue to review full report at Codecov.
|
This is useful to have and something that is needed for Nabla invenia/Nabla.jl#189
(It is extracted out of that PR)