Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CI #14

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Clean up CI #14

merged 2 commits into from
Jan 14, 2021

Conversation

fchorney
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #14 (e946cd0) into master (136ef24) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   99.42%   99.37%   -0.06%     
==========================================
  Files           4        4              
  Lines         173      159      -14     
==========================================
- Hits          172      158      -14     
  Misses          1        1              
Impacted Files Coverage Δ
src/function.jl 98.76% <0.00%> (-0.03%) ⬇️
src/method.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136ef24...e946cd0. Read the comment docs.

# Add a 1.0 job just to make sure we still support it
- os: ubuntu-latest
version: 1.0.5
arch: x64
# Add a 1.3 job because that's what Invenia actually uses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add a 1.3 job because that's what Invenia actually uses
# Add a 1.5 job because that's what Invenia actually uses

# Add a 1.0 job just to make sure we still support it
- os: ubuntu-latest
version: 1.0.5
arch: x64
# Add a 1.3 job because that's what Invenia actually uses
- os: ubuntu-latest
version: 1.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 1.3
version: 1.5

@fchorney fchorney merged commit 44ee460 into master Jan 14, 2021
@fchorney fchorney deleted the fc/fix-ci branch January 14, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants