fix: null checking on client root

intuit · Aug 26, 2021 · fed04a3 · fed04a3
1 parent 21621c7
commit fed04a3
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/src/commands/install.ts b/src/commands/install.ts
@@ -60,9 +60,12 @@ export default class InstallCommand extends UpdateCommand {
       this.channel = 'stable';
     }
 
-    const versions = fs
-      .readdirSync(this.clientRoot)
-      .filter((dirOrFile) => dirOrFile !== 'bin' && dirOrFile !== 'current');
+    let versions: string[] = [];
+    try {
+      versions = fs
+        .readdirSync(this.clientRoot)
+        .filter((dirOrFile) => dirOrFile !== 'bin' && dirOrFile !== 'current');
+    } catch {}
 
     if (versions.includes(targetVersion)) {
       this.log(

diff --git a/src/commands/update.ts b/src/commands/update.ts
@@ -71,9 +71,15 @@ export default class UpdateCommand extends Command {
       );
 
       // Do not show known non-local version folder names, bin and current.
-      const versions = fs
-        .readdirSync(this.clientRoot)
-        .filter((dirOrFile) => dirOrFile !== 'bin' && dirOrFile !== 'current');
+      let versions: string[] = [];
+      try {
+        versions = fs
+          .readdirSync(this.clientRoot)
+          .filter(
+            (dirOrFile) => dirOrFile !== 'bin' && dirOrFile !== 'current',
+          );
+      } catch {}
+
       if (versions.length === 0)
         throw new Error('No locally installed versions found.');
 

diff --git a/src/commands/use.ts b/src/commands/use.ts
@@ -53,9 +53,12 @@ export default class UseCommand extends UpdateCommand {
     this.debug(`Looking for locally installed versions at ${this.clientRoot}`);
 
     // Do not show known non-local version folder names, bin and current.
-    const versions = fs
-      .readdirSync(this.clientRoot)
-      .filter((dirOrFile) => dirOrFile !== 'bin' && dirOrFile !== 'current');
+    let versions: string[] = [];
+    try {
+      versions = fs
+        .readdirSync(this.clientRoot)
+        .filter((dirOrFile) => dirOrFile !== 'bin' && dirOrFile !== 'current');
+    } catch {}
 
     // Back out if no local versions are found
     if (versions.length === 0)