Adding Option to give users finer control of what results get cached. #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background information
Our team is currently using the Funnel to cache network request.
It was noticed that error responses are also cached, which is less then ideal.
Implementation summary
Add an Option to the Funnel constructor that takes in a predicate that will return true if a result
should be cached and false otherwise. The predicate will have the following signature func(interface{}, error)bool
which matches the return value from the execute.
With this solutions user can chose to have complete control of what results get cached or whether to use the default behavior.
Before & after
Before:
No option to control what gets cached.
After:
func WithShouldCachePredicate(p func(interface{}, error) bool) Option {
return func(cfg *Config) {
cfg.shouldCache = p
}
}
Risk mitigation
Unit test has been added to cover the new Option
Ticket
https://jira.mailchimp.com/browse/DATABRIDGE-1003