Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated docs:watch script #1557

Merged
merged 2 commits into from
Oct 2, 2020
Merged

chore: updated docs:watch script #1557

merged 2 commits into from
Oct 2, 2020

Conversation

christyjacob4
Copy link

@christyjacob4 christyjacob4 commented Oct 2, 2020

What Changed

The docs:watch command was added to package.json

Why

The README contains a script to build and run the docs but the command was missing from package.json

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@adierkens adierkens added the minor Increment the minor version when merged label Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #1557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1557   +/-   ##
=======================================
  Coverage   81.21%   81.21%           
=======================================
  Files          60       60           
  Lines        4413     4413           
  Branches      986      986           
=======================================
  Hits         3584     3584           
  Misses        573      573           
  Partials      256      256           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e1f40...dd4c508. Read the comment docs.

@hipstersmoothie
Copy link
Collaborator

Can you delete this from the package.json and update the readme to just say yarn docs since that command already exists

@christyjacob4
Copy link
Author

Sure @hipstersmoothie I can do that 👍

@adierkens adierkens added the documentation Changes only affect the documentation label Oct 2, 2020
@hipstersmoothie hipstersmoothie removed the minor Increment the minor version when merged label Oct 2, 2020
@hipstersmoothie hipstersmoothie merged commit 5059c52 into intuit:master Oct 2, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.54.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants