test: update node requirement and add small test #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimClarkson
approved these changes
Oct 17, 2019
|
🚀 PR was released in v1.0.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing this pull request!
Please make the PR against the
masterbranch, add a description of what's changing, and link any relevant issues or PRs.What's changing
update the document to use node 10. (required me to be >=10 when I was using node 8)
add a small test inside of duplicate model, binding the onChange.
...
What else might be impacted?
Please correct me if the node documentation should not be 10. It did not allow me to yarn due to required node versions and the README was not following it.
...
Checklist
[x] Unit tests (updated and/or added)
[x] Documentation (function/class docs, comments, etc.)
Published PR with canary version:
1.0.1-canary.21.230.0