Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatability with php8.4 #540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

craig-mcmahon
Copy link

This change prevents deprecations warnings such the following occurring when running on php 8.4

PHP Deprecated:  QuickBooksOnline\API\Core\OAuth\OAuth2\OAuth2LoginHelper::__construct(): Implicitly marking parameter $serviceContext as nullable is deprecated, the explicit nullable type must be used instead

This change requires php 7.1, but given that there is a requirement on guzzlehttp/guzzle version ^7.9 this implies a minimum version of php 7.2.5 which I have replicated in composer.json to make it clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant