Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncap numpy version to fix installation on Python 3.12 #27

Merged

Conversation

architkulkarni
Copy link

The numpy version was capped at <1.25, which fails to install on Python 3.12 (numpy/numpy#23808). This PR uncaps the numpy version. The reason for the cap was some version compatibility issue with numba, but numba doesn't seem to be imported anywhere currently.

Closes #19, closes #16

Tested with

conda create --name test python=3.12 -y
conda activate test
pip install -e .

@jonathan-taylor jonathan-taylor merged commit c50b45b into intro-stat-learning:main Jun 4, 2024
@jonathan-taylor
Copy link
Collaborator

Uncapping numpy requirement (previously there for a numba issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation broken on python 3.12 Error in installing ISLP on python 3.12.1
2 participants