Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[_]: feat/Range Slider component #11

Merged
merged 5 commits into from
Oct 24, 2024
Merged

[_]: feat/Range Slider component #11

merged 5 commits into from
Oct 24, 2024

Conversation

xabg2
Copy link
Collaborator

@xabg2 xabg2 commented Oct 23, 2024

Adding the Range Slider component with its CSS and tests.

The vite-plugin-css-injected-by-js package is needed to compile the component with its CSS, so we don't need to import the styling into our project along with the component.

On the other hand, we have had problems running storybook), it seems we have to use yarn 4, but I have found a workaround:

"resolutions": {
    "jackspeak": "2.1.1"
  },

@xabg2 xabg2 added the enhancement New feature or request label Oct 23, 2024
@xabg2 xabg2 self-assigned this Oct 23, 2024
Copy link
Collaborator

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabg2 review the test that is failing

@xabg2 xabg2 requested a review from CandelR October 24, 2024 07:30
@xabg2 xabg2 merged commit 8723ba4 into master Oct 24, 2024
1 check passed
@xabg2 xabg2 deleted the feat/slider-component branch October 24, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants