[PB-2424] Feat: user can't shared item details #268
+49
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
CandelR
approved these changes
Dec 26, 2024
src/drive/storage/index.ts
Outdated
| @@ -642,6 +643,20 @@ export class Storage { | |||
| return this.client.get<FolderAncestor[]>(`folders/${uuid}/ancestors?isSharedItem=${isShared}`, this.headers()); | |||
| } | |||
|
|
|||
| /** | |||
| * Gets the ancestors of a given UUID and type | |||
There was a problem hiding this comment.
nit: Gets the ancestors of an item with the given UUID and type
…tem in Workspaces
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
==========================================
- Coverage 63.16% 62.86% -0.30%
==========================================
Files 41 42 +1
Lines 1474 1508 +34
Branches 229 239 +10
==========================================
+ Hits 931 948 +17
- Misses 476 487 +11
- Partials 67 73 +6 ☔ View full report in Codecov by Sentry. |
CandelR
requested changes
Dec 30, 2024
|
@jvedrson please, review this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until WIP is merged
Ticket
Updates
itemTypeandUuidPR related