Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep up with Code Quality Ratings #153

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Conversation

sg-gs
Copy link
Member

@sg-gs sg-gs commented Nov 22, 2023

These changes aim to keep the repo updated and are part of the maintenance. The most relevants are:

  • Regarding the virtualization of the project:
    • Improve security through using a non-root user to run the server & by reducing the vulnerabilities a 70%. (L/M/H)
    • Reduce the Docker image size a 25%
  • Update the core tests
  • Upgrade the Node.js version in GH Actions to v16

@sg-gs sg-gs added the enhancement New feature or request label Nov 22, 2023
@sg-gs sg-gs self-assigned this Nov 22, 2023
@sg-gs sg-gs changed the title [_]: feat/keep up with quality ratings Keep up with Code Quality Ratings Nov 22, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 94 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (1b94efa) 14.93% compared to head (a1ceb80) 15.68%.
Report is 31 commits behind head on master.

Files Patch % Lines
lib/server/routes/buckets.js 0.00% 15 Missing ⚠️
lib/core/buckets/usecase.ts 35.71% 7 Missing and 2 partials ⚠️
lib/core/users/usecase.ts 50.00% 3 Missing and 1 partial ⚠️
lib/server/routes/frames.js 0.00% 4 Missing ⚠️
lib/server/routes/gateway.js 0.00% 3 Missing ⚠️
lib/core/users/MongoDBUsersRepository.ts 33.33% 1 Missing and 1 partial ⚠️
lib/server/routes/stripe.js 0.00% 2 Missing ⚠️
lib/core/buckets/MongoDBBucketsRepository.ts 50.00% 0 Missing and 1 partial ⚠️
lib/server/routes/index.js 0.00% 1 Missing ⚠️
lib/server/routes/users.js 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   14.93%   15.68%   +0.75%     
==========================================
  Files          46       46              
  Lines        3081     2932     -149     
  Branches      618      590      -28     
==========================================
  Hits          460      460              
+ Misses       2158     2037     -121     
+ Partials      463      435      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sg-gs sg-gs merged commit 2bd5e15 into master Nov 22, 2023
4 checks passed
@sg-gs sg-gs deleted the feat/keep-up-with-quality-ratings branch November 22, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants