Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrivTokenAuthChecker resets ignoreRobots switch turned off by EmbeddedCDXServer #51

Closed
kngenie opened this issue Nov 28, 2014 · 2 comments
Closed

PrivTokenAuthChecker resets ignoreRobots switch turned off by EmbeddedCDXServer #51

kngenie opened this issue Nov 28, 2014 · 2 comments
Labels
bug

Comments

@kngenie
Copy link
Member

kngenie commented Nov 28, 2014

EmbeddedCDXServer has a feature that turns off robots exclusion check for embeds, but it is not working at all because PrivTokenAuthChecker.isAllUrlAccessAllowed() method turns robots exclusion flag on again.

I consider it a bad practice for getter method to have this kind of side-effect.
@kngenie kngenie added the bug label Nov 28, 2014
@kngenie
Copy link
Member Author

kngenie commented Nov 28, 2014

Fix is on WWM-119 branch and ready for merge.

@kngenie
Copy link
Member Author

kngenie commented Jan 19, 2015

Merged to iipc/master at 1dbd4f3

@kngenie kngenie closed this as completed Jan 19, 2015
kngenie pushed a commit that referenced this issue May 30, 2015
@johnerikhalse
Merge pull request #199 from nlnwa/issue51_nhc_start_date
e6195c1 
Fix for issue #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kngenie